chore: Update package, apply new readme style #3
Conversation
ptrcksc
commented
Aug 21, 2024
•
ptrcksc
commented
- add phpstan
- add php-cs-fixer
- run code-styling
- format readme
- update composer dependencies, add minimum php 8.1 check
ptrcksc
changed the title
| ## Installation | ||
| ## Quick start | ||
|
|
||
| ### Installation |
There was a problem hiding this comment.
Would it be good to also indicate in the readme what the minimum requirements are? For example because the PHP version has now gone to 8.1?
There was a problem hiding this comment.
The PHP version is set in the composer.json file. I personally think this is clean enough, as a user I would expect this to follow Nova's minimum requirements, and PHP's supported versions.
Right now Nova is laravel8/PHP7.3, minimum supported PHP version is 8.1, so PHP 8.1?
There was a problem hiding this comment.
You often see the versions in readme's. Even though a version is configured in composer.json and the package relies on Nova, it wouldn't hurt to put it in the readme, so anyone that wants to use the package can immediately see what the minimum requirements are.
|
@ptrcksc One more thing I forgot: |
